-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug fix] box points ordering #1205
Conversation
Codecov ReportBase: 83.58% // Head: 83.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
==========================================
- Coverage 83.58% 83.53% -0.06%
==========================================
Files 170 170
Lines 11377 11365 -12
Branches 1696 1694 -2
==========================================
- Hits 9510 9494 -16
- Misses 1489 1492 +3
- Partials 378 379 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi, thank you for your contribution. We will review this code as soon as possible. At the same time, could you please sign the CLA shown on this page? So we can accept your contribution once it has been fully reviewed. Besides, since your PR hasn't passed our linting test, please follow the instruction to install |
If you have some advice, i will correct it right now. |
|
* fix sort_points * remove functools * add test cases * add descriptions for coordinates * del Co-authored-by: xinyu <wangxinyu2017@gmail.com>
* [Bug fix] box points ordering (#1205) * fix sort_points * remove functools * add test cases * add descriptions for coordinates * del Co-authored-by: xinyu <wangxinyu2017@gmail.com> * fix --------- Co-authored-by: liferecords <yjmm10@yeah.net> Co-authored-by: xinyu <wangxinyu2017@gmail.com>
Dear yjmm10, First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG Thank you again for your contribution❤ Best regards!@yjmm10 |
This changes optimize sort_points function, mainly using the Cartesian coordinate system to convert point coordinates to a cartesian coordinate system, and then sort the polar coordinate points
The change also ensures the original command-line usage remains the same.